Author: alexfh Date: Wed Apr 3 07:03:43 2019 New Revision: 357582 URL: http://llvm.org/viewvc/llvm-project?rev=357582&view=rev Log: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method
Summary: All in-tree clang-tidy checks have been migrated to the new ClangTidyCheck::registerPPCallbacks method. Time to drop the old one. Reviewers: sammccall, hokein Reviewed By: hokein Subscribers: xazax.hun, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D60197 Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp?rev=357582&r1=357581&r2=357582&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Wed Apr 3 07:03:43 2019 @@ -393,7 +393,6 @@ ClangTidyASTConsumerFactory::CreateASTCo for (auto &Check : Checks) { Check->registerMatchers(&*Finder); - Check->registerPPCallbacks(Compiler); Check->registerPPCallbacks(*SM, PP, ModuleExpanderPP); } Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h?rev=357582&r1=357581&r2=357582&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h (original) +++ clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h Wed Apr 3 07:03:43 2019 @@ -53,9 +53,6 @@ public: /// constructor using the Options.get() methods below. ClangTidyCheck(StringRef CheckName, ClangTidyContext *Context); - /// DEPRECATED: Use the other overload. - virtual void registerPPCallbacks(CompilerInstance &Compiler) {} - /// \brief Override this to register ``PPCallbacks`` in the preprocessor. /// /// This should be used for clang-tidy checks that analyze preprocessor- Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/ClangdUnit.cpp?rev=357582&r1=357581&r2=357582&view=diff ============================================================================== --- clang-tools-extra/trunk/clangd/ClangdUnit.cpp (original) +++ clang-tools-extra/trunk/clangd/ClangdUnit.cpp Wed Apr 3 07:03:43 2019 @@ -299,7 +299,6 @@ ParsedAST::build(std::unique_ptr<Compile for (const auto &Check : CTChecks) { // FIXME: the PP callbacks skip the entire preamble. // Checks that want to see #includes in the main file do not see them. - Check->registerPPCallbacks(*Clang); Check->registerPPCallbacks(Clang->getSourceManager(), PP, PP); Check->registerMatchers(&CTFinder); } Modified: clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h?rev=357582&r1=357581&r2=357582&view=diff ============================================================================== --- clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h (original) +++ clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h Wed Apr 3 07:03:43 2019 @@ -42,7 +42,6 @@ private: Preprocessor *PP = &Compiler.getPreprocessor(); for (auto &Check : Checks) { Check->registerMatchers(&Finder); - Check->registerPPCallbacks(Compiler); Check->registerPPCallbacks(Compiler.getSourceManager(), PP, PP); } return Finder.newASTConsumer(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits