Why would we want this to be different in Obj-C and C++? On Thu, Apr 4, 2019 at 9:34 AM Krasimir Georgiev via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> wrote:
> krasimir marked 2 inline comments as done. > krasimir added inline comments. > > > ================ > Comment at: lib/Format/Format.cpp:787 > GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$"; > GoogleStyle.IncludeStyle.IncludeBlocks = > tooling::IncludeStyle::IBS_Regroup; > GoogleStyle.IndentCaseLabels = true; > ---------------- > ioeric wrote: > > maybe we should also only use regroup for cpp? `regroup` is only > supported in `sortCppIncludes` after all. > Yeah, but they are just not used for unrelated languages. This argument > applies to the other fields in the IncludeStyle group above this. I'd lean > on keeping this as-is. > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D60263/new/ > > https://reviews.llvm.org/D60263 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
