ABataev added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { ---------------- 1. Why this change is required? 2. Why not a `SmallString`? ================ Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:323 + +// CHECK-NOT: _ZGV{{.+}}__Z1fRA_i ---------------- Hmm, a very strange update of the test, just quotes are removed and nothing else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40577/new/ https://reviews.llvm.org/D40577 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits