ztamas marked an inline comment as done. ztamas added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:51 + // Matcher for standard smart pointers. + const auto SmartPointerType = qualType(hasUnqualifiedDesugaredType( + recordType(hasDeclaration(classTemplateSpecializationDecl( ---------------- xazax.hun wrote: > JonasToth wrote: > > what about `auto_ptr`? I am actually not sure if we should care, as its > > deprecated and removed already, on the other hand legacy code probably > > still has it. > I am perfectly fine with addressing this in a follow-up patch or even not > addressing at all, but I think for some users it might be useful to be able > to specify a set of suspicious types as a configuration option such as custom > smart pointers, handles and so on. Seems a good idea for a follow-up change. Actually, with an earlier version of this patch I found another vulnerable copy assignment operator in llvm code which uses a custom pointer type (PointerIntPair): FunctionInfo &operator=(const FunctionInfo &RHS) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
