tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: lib/Driver/Driver.cpp:652 @@ -640,3 +651,3 @@ SmallVector<std::pair<int, const Command *>, 4> FailingCommands; - C.ExecuteJobs(C.getJobs(), FailingCommands); + C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands); ---------------- As far as I can tell, we don't do anything interesting if we've detected that *any* of the commands have failed. That suggests that doing anything beyond the first failing command does not do us any good. That would suggest that we may really want StopOnFailure=true here. 'false' would preserve current behavior, though. In either case I'm OK with a constant here. http://reviews.llvm.org/D16514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
