t.p.northover added inline comments.
================
Comment at: include/clang/Sema/Sema.h:10762
bool AllowName);
+ bool SemaBuiltinARMMemoryTaggingCall(unsigned BuiltinID, CallExpr *TheCall);
public:
----------------
Slightly misaligned.
================
Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131
+ // Although it is possible to supply a different return
+ // address (first arg) to this intrinsic, for now we set
+ // return address same as input address.
----------------
I think this should be fixed now. It looks like technical debt from the fact
that the instructions only fairly recently gained that feature after the
intrinsics were implemented internally. There's no good way to justify the
current semantics to someone unaware of that history.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60485/new/
https://reviews.llvm.org/D60485
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
