rnk added inline comments.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:55-56
+ bool passClassIndirect(const CXXRecordDecl *RD) const {
+ return !canCopyArgument(RD);
+ }
----------------
These are both trivial wrappers for `RD->canPassInRegisters()` which has the
real logic. I would just call that to remove some indirection, even if the name
is the logical opposite of the property we're trying to check.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1079
+ return true;
+ for (auto it = RD->ctor_begin(); it != RD->ctor_end(); ++it) {
+ if (it->isUserProvided())
----------------
Can this be just: `for (const CXXConstructorDecl *Ctor : RD->ctors())`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60349/new/
https://reviews.llvm.org/D60349
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
