rjmccall added inline comments.
================ Comment at: lib/CodeGen/CGObjCMac.cpp:1024 + bool AddToUsed, + bool ExplicitDataSegment); llvm::GlobalVariable *CreateMetadataVar(Twine Name, ---------------- Please document what this parameter means. ================ Comment at: lib/CodeGen/CGObjCMac.cpp:1978 + ? llvm::GlobalVariable::InternalLinkage + : llvm::GlobalValue::PrivateLinkage); // FIXME. Fix section. ---------------- 1. Why are these using different classes to name these enumerators? 2. Why are we promoting to internal linkage in some cases? That seems to be an additional semantic change not discussed in the commit message, and it should probably also get a good inline comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/ https://reviews.llvm.org/D61454 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
