jdenny added reviewers: rsmith, aaron.ballman. jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land.
LGTM except for nits in the tests. I'm not close to C++ support in Clang, so please give other reviewers a few days to comment just in case. I've added a couple who have reviewed my patches in this area in the past. Thanks for the fix! ================ Comment at: clang/test/AST/ast-print-record-decl.c:303 + }; +} +#endif ---------------- To make this easier to read (especially in editors without highlighting), I suggest putting all FileCheck directives for the definition of each of `struct DeclEnclosing` and `struct DeclEnclosing::DeclMember` before that definition. ================ Comment at: clang/test/AST/ast-print-record-decl.c:307 // A tag decl group in the tag decl's own member list is exercised in // defSelfRef above. ---------------- This comment should stay next to `DeclGroupInMemberList` because they're both about tag decl groups in member lists. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
