JDevlieghere added inline comments.
================ Comment at: lib/Headers/CMakeLists.txt:36 bmiintrin.h + openmp_wrappers/math.h + openmp_wrappers/cmath ---------------- hfinkel wrote: > JDevlieghere wrote: > > This doesn't do what you think it would do. The files are copied into the > > root of the resource directory, which causes stage 2 build failures on > > GreenDragon. > Can you provide a link to the failure log? Is the problem that the files are > not copied into their subdirectory? Correct. There's not much to see, but here's a build that fails because of this: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/25557/console ``` CMake Error at cmake/modules/HandleLLVMOptions.cmake:497 (message): LLVM_ENABLE_MODULES is not supported by this compiler ``` The cmake log output, which I grabbed from the bot is more descriptive: ``` Performing C++ SOURCE FILE Test CXX_SUPPORTS_MODULES failed with the following output: Change Dir: /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/CMakeFiles/CMakeTmp Run Build Command:"/usr/local/bin/ninja" "cmTC_0dd11" [1/2] Building CXX object CMakeFiles/cmTC_0dd11.dir/src.cxx.o FAILED: CMakeFiles/cmTC_0dd11.dir/src.cxx.o /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -DCXX_SUPPORTS_MODULES -Werror=unguarded-availability-new -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/module.cache -fcxx-modules -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -mmacosx-version-min=10.9 -o CMakeFiles/cmTC_0dd11.dir/src.cxx.o -c src.cxx While building module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/assert.h:42: While building module 'std' imported from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/tgmath.h:27: In file included from <module-includes>:2: /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/../include/c++/v1/ctype.h:38:15: fatal error: cyclic dependency in module 'Darwin': Darwin -> std -> Darwin #include_next <ctype.h> ^ While building module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/assert.h:42: In file included from <module-includes>:89: In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/lib/clang/9.0.0/include/tgmath.h:21: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/tgmath.h:27:10: fatal error: could not build module 'std' #include <math.h> ~~~~~~~~^ In file included from src.cxx:2: In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/../include/c++/v1/cassert:20: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/assert.h:42:10: fatal error: could not build module 'Darwin' #include <sys/cdefs.h> ~~~~~~~~^ 3 errors generated. ninja: build stopped: subcommand failed. Source file was: #undef NDEBUG #include <cassert> #define NDEBUG #include <cassert> int main() { assert(this code is not compiled); } ``` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
