aprantl added inline comments. ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:2099 @@ -2098,1 +2098,3 @@ +llvm::DIMacro *CGDebugInfo::CreateMacro(llvm::DIMacroFile *Parent, bool IsUndef, + SourceLocation LineLoc, StringRef Name, ---------------- By using a bool for IsUndef, we'll end up with somewhat ugly call sites like DI->CreateMacro(Parent, /*IsUndef*/ true, ...); so we might as well just pass in the dwarf constant DI->CreateMacro(Parent, llvm::dwarf::DW_MACINFO_undef, ...); directly.
http://reviews.llvm.org/D16135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
