vsapsai added a comment. In D61621#1497027 <https://reviews.llvm.org/D61621#1497027>, @rnk wrote:
> lgtm, thanks! > > In D61621#1496978 <https://reviews.llvm.org/D61621#1496978>, @vsapsai wrote: > > > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > > Don't know if it is accidental and if I should add the flag. > > > `-fms-extensions` is probably all you need. That's the one that defines > _MSC_VER. Thanks for extra information and for the review. In my testing it was `-fms-compatibility-version` that defines `_MSC_VER` on macOS. I haven't tested extensively but looks like for the driver `-fms-extensions` should be enough but for -cc1 you need `-fms-compatibility-version`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61621/new/ https://reviews.llvm.org/D61621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
