Szelethus added a comment.

I committed but changed the moves to copies. Singel 
`CheckerRegisrty::CmdLineOption` is only filled with `StringRef`s, it shouldn't 
really matter.



================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:314
 insertOptionToCollection(StringRef FullName, T &Collection,
-                         const CheckerRegistry::CmdLineOption &&Option) {
+                         const CheckerRegistry::CmdLineOption &&Option,
+                         AnalyzerOptions &AnOpts) {
----------------
NoQ wrote:
> Mmm, const rvalue reference? Is this even a thing?
Apparently :D


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57922/new/

https://reviews.llvm.org/D57922



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to