theraven added inline comments.
================
Comment at: lib/AST/ASTContext.cpp:6973
QualType PointeeTy = OPT->getPointeeType();
- if (!Options.EncodingProperty() &&
+ if (getLangOpts().ObjCRuntime.isGNUFamily() &&
+ !Options.EncodingProperty() &&
----------------
ahatanak wrote:
> theraven wrote:
> > Please can we at least make this check just for the GCC runtime? I'm not
> > sure it's even needed there. I've previously had to write code that works
> > around this and have always considered it a bug in GCC, rather than a
> > feature that I'd like us to copy, so I'd also be happy with just deleting
> > this code path entirely.
> >
> Are we allowed to delete the code path entirely? That would clean up the code
> a bit, but I assume it would also break GCC runtime users' code.
I'd be happy with deleting it entirely. Nothing in the gcc runtime itself
depends on it and all of the code that I've dealt with that works with the GCC
runtime and this functionality has explicit work arounds for this behaviour in
GCC.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61974/new/
https://reviews.llvm.org/D61974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
