ABataev added a comment. Looks good, in general. Just one more question: will __tgt_register_requires be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, this function should not be called, I think, because we're not going to use offloading at all in this case and __tgt_register_requires should not be emitted. Otherwise, we may end up with the linker error that __tgt_register_requires is not found. Would be good to have a test with -fopenmp and #pragma omp requires that check that no __tgt_register_requires is emitted in this case.
Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
