stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed.
Many thanks for being patient with me 🙏 I think there are just two more things ✌️ ❧ Sorry, I think my earlier description was understated. Maybe this would be a better commit description: """ Revise the google-objc-global-variable-declaration check to match the style guide. This commit updates the check as follows: (1) Do not emit fixes for extern global constants. (2) Allow the second character of prefixes for constants to be numeric (the new guideline is that global constants should generally be named with a prefix that begins with a capital letter followed by one or more capital letters or numbers). https://google.github.io/styleguide/objcguide.html#prefixes """ (sorry I am a bit disorganized since I have been juggling various things today) ================ Comment at: clang-tools-extra/clang-tidy/google/CMakeLists.txt:17 OverloadedUnaryAndCheck.cpp + TestCheck.cpp TodoCommentCheck.cpp ---------------- This change doesn't look like it belongs in this commit? Please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
