gribozavr marked 2 inline comments as done. gribozavr added inline comments.
================ Comment at: clang/include/clang/AST/Stmt.h:1057 + Stmt() = delete; Stmt(const Stmt &) = delete; ---------------- ilya-biryukov wrote: > gribozavr wrote: > > ilya-biryukov wrote: > > > NIT: Move the deleted declarations to the start of the class? > > > Or move the deleted declarations in other classes to the first public > > > section? > > > > > > (For consistency) > > I put these new declarations close to the "primary" constructor. > Why not move declarations inside `Stmt` to the primary constructor too? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62187/new/ https://reviews.llvm.org/D62187 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
