leonardchan marked 4 inline comments as done.
leonardchan added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105
// which is just that always inlining occurs.
- MPM.addPass(AlwaysInlinerPass());
+ // We always pass false here since according to the legacy PM logic for
+ // enabling lifetime intrinsics, we should not be compiling with O0.
+ MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false));
----------------
serge-sans-paille wrote:
> echristo wrote:
> > Can you elaborate more here? We do turn on the always inliner at O0 which
> > makes this comment a bit confusing.
> I guess he means
>
> We always pass false here since according to the legacy PM logic for
> enabling lifetime intrinsics, they are not required with O0
>
Yup, my bad. This is what I meant with this comment. Always inlining is used.
It's the lifetime intrinsics that aren't always used.
================
Comment at: clang/test/CodeGen/aarch64-neon-fma.c:235
// CHECK: attributes #1 ={{.*}}"min-legal-vector-width"="128"
+// CHECK: attributes [[NOUNWIND_ATTR]] = { nounwind }
----------------
echristo wrote:
> Do we really need to check for it or does the autogeneration of testcases do
> some of this?
I do not know if this is actually an autogenerated test, but if so then
probably not. Is there a way to check this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62225/new/
https://reviews.llvm.org/D62225
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
