gtbercea marked an inline comment as done.
gtbercea added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956
+    // If using unified memory, no need to do the mappings.
+    if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport())
+      return;
----------------
ABataev wrote:
> Hmm, what about regular declare target declarations? Also, this is not 
> enough. You also should not capture such variables in the captured regions.
For now, only variables under the link clause are considered for unified memory 
usage.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60883/new/

https://reviews.llvm.org/D60883



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to