boga95 marked 3 inline comments as done. boga95 added a comment. I already thought about it. It would make the code much cleaner, but it would have a little performance impact (Does it matter?). It's straightforward to read the supported functions from another yaml file. Besides that, it can support multiple config files too.
================ Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75 static const unsigned InvalidArgIndex = UINT_MAX; /// Denotes the return vale. static const unsigned ReturnValueIndex = UINT_MAX - 1; ---------------- boga95 wrote: > Szelethus wrote: > > boga95 wrote: > > > Szelethus wrote: > > > > We should definitely change these, not only is the large integer number > > > > impossible to remember, but this value could differ on different > > > > platforms. > > > I tried to use int, but I got a lot of warnings because of the > > > `getNumArgs()` returns an unsigned value. > > What warnings? I thought we have `-Wsign-conversion` disabled. > I got `-Wsign-compare` warnings, but it compiles. I will change it in the > next [[ https://reviews.llvm.org/D59637 | review ]] because that's contains > the yaml file and the related tests. Now, this is just for internal representation. The -1 value is mapped to this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
