mgorny marked 2 inline comments as done.
mgorny added inline comments.

================
Comment at: libunwind/test/libunwind/test/config.py:27
+        self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root')
+            or os.path.join(self.libunwind_src_root, '../libcxx'))
 
----------------
phosek wrote:
> Can you use `os.path.join(self.libunwind_src_root, '..', 'libcxx')` to make 
> it compatible with systems that don't use `/` as path separators?
Good catch. Will do.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62005/new/

https://reviews.llvm.org/D62005



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to