nridge marked an inline comment as done. nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected<RelationKind> symbolRoleToRelationKind(index::SymbolRole); ---------------- kadircet wrote: > kadircet wrote: > > why not start from zero? > > > > Also let's change the `index::SymbolRole` in `Relation` with this one. > why not just store baseof ? do we need both directions for typehierarchy? > Also let's change the index::SymbolRole in Relation with this one. You previously asked for the opposite change in [this comment](https://reviews.llvm.org/D59407?id=190785#inline-525734) :) Did your opinion change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62459/new/ https://reviews.llvm.org/D62459 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits