arsenm marked an inline comment as done. arsenm added inline comments.
================ Comment at: lib/CodeGen/TargetInfo.cpp:7885 + // By default, restrict the maximum size to 256. + F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } ---------------- yaxunl wrote: > arsenm wrote: > > b-sumner wrote: > > > Theoretically, shouldn't the minimum be 1? > > That's what I thought, but the backend is defaulting to 2 * wave size now > I don't get it. This attribute indicates the possible workgroup size range > this kernel may be run with, right? It only depends on how user execute the > kernel. How is it related to backend defaults? The backend currently assumes 128,256 by default as the bounds. I want to make this a frontend decision, and make the backend assumption the most conservative default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits