philip.pfaffe added a subscriber: beanz.
philip.pfaffe added a comment.

I fear you'll need to plan at least for new pm right now. Otherwise your change 
will be obsolete in half a year. What is it really that LINK_X_INTO_TOOLS is 
supposed to do? Effectively bake in something that's consumable by -load or 
-load-plugin, right? So can we use that interface directly? Effectively, can we 
have statically built-in plugins, that prepopulate the plug-in loader 
mechanisms?

If the patch becomes too large then it should be split into separate functional 
units, e.g., one adding the cmake functionality, one updating the plugins and 
the tools.

You could also ask @beanz for a review of the cmake change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to