asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Jim.
This looks good to me, but is blocked on the dependent patch being updated. I added a minor comment on riscv-inline-asm.c ================ Comment at: test/CodeGen/riscv-inline-asm.c:1 +// RUN: %clang_cc1 -triple riscv32 -target-feature +f -O2 -emit-llvm %s -o - \ +// RUN: | FileCheck %s ---------------- No need to enable +f for the test, as written. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54091/new/ https://reviews.llvm.org/D54091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
