hubert.reinterpretcast added inline comments.
================
Comment at: docs/ReleaseNotes.rst:79
- ``clang -dumpversion`` now returns the version of Clang itself.
+ Similarly, __VERSION__ returns the Clang version instead of 4.2.1.
----------------
Use code font for `__VERSION__`.
================
Comment at: lib/Frontend/InitPreprocessor.cpp:607
- // As sad as it is, enough software depends on the __VERSION__ for version
- // checks that it is necessary to report 4.2.1 (the base GCC version we claim
- // compatibility with) first.
- Builder.defineMacro("__VERSION__", "\"4.2.1 Compatible " +
- Twine(getClangFullCPPVersion()) + "\"");
+ // We used to report 4.2.1 as compatibility with gcc
+ // Now, we returns the clang version.
----------------
s/as/for/; s/gcc/GCC/;
Add a period to the end of the sentence.
================
Comment at: lib/Frontend/InitPreprocessor.cpp:608
+ // We used to report 4.2.1 as compatibility with gcc
+ // Now, we returns the clang version.
+ Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING
----------------
s/returns/return/; s/clang/Clang/;
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63048/new/
https://reviews.llvm.org/D63048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
