rjmccall added inline comments.

================
Comment at: lib/CodeGen/TargetInfo.cpp:1005
   bool IsMCUABI;
+  bool IsLinuxABI;
   unsigned DefaultNumRegisterParameters;
----------------
mgorny wrote:
> Maybe replace the two booleans with something alike `IsPassInMMXRegABI`? And 
> while at it, include NetBSD there, please.
`CGT` is a member variable, so you can just query the target fresh in your 
`isPassInMMXRegABI` method.  The check upfront for a 64-bit vector type should 
keep this well out of the fast path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59744/new/

https://reviews.llvm.org/D59744



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to