aaronpuchert added a subscriber: tejohnson.
aaronpuchert added inline comments.


================
Comment at: lib/CodeGen/BackendUtil.cpp:1345
   Conf.RemarksPasses = CGOpts.OptRecordPasses;
-  Conf.DwoPath = CGOpts.SplitDwarfFile;
+  Conf.DwoPath = CGOpts.SplitDwarfOutput;
   switch (Action) {
----------------
aaronpuchert wrote:
> @pcc Your documentation for `DwoPath` suggests that this should be the actual 
> output filename. However, the test that you added together with this line in 
> rC333677 doesn't fail whatever garbage I write into that field here. What can 
> I add to that so that it fails when we don't do the right thing here?
@pcc Could you (or perhaps @tejohnson) comment on what the intended behavior is 
here, and how I can change the test so that it fails when I do the wrong thing? 
Is this the name of the file we write the split debug info to, or is it the 
value we use for the DW_AT_[GNU_]dwo_name attribute in the skeleton CU?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59673/new/

https://reviews.llvm.org/D59673



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to