kadircet marked 3 inline comments as done. kadircet added inline comments.
================ Comment at: clang/lib/Driver/Driver.cpp:1055 + else if (ClangNameParts.TargetIsValid) + TargetTriple = ClangNameParts.TargetPrefix; + ---------------- ilya-biryukov wrote: > I strongly think the driver is the right place to do this, but we have to > watch out for breakages coming from this. The drivers code has way more uses > than clangd code, so we should expect that people rely on all kinds of things > there. > > Could you separate the driver pieces into a separate change and add driver > tests for them? To make it more focused and easier to revert in case of > breakages. sent out D63264 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
