gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:33 + StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), Rule(MakeRule(getLangOpts(), Options)) { + assert(llvm::all_of(Rule.Cases, [](const RewriteRule::Case &C) { ---------------- Can we dispatch to the other constructor? ================ Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:40 +} + void TransformerClangTidyCheck::registerMatchers( ---------------- Keep the definition order of constructors consistent with declaration order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63288/new/ https://reviews.llvm.org/D63288 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits