efriedma added a comment.

For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && 
!defined(__LP64__)`, but I don't think the alternative is better.  We could 
restrict the test so it doesn't run using a Solaris target triple, but we 
actually want coverage here: the difference in wint_t affects the semantics of 
"%lc", so we want some coverage of that path.

The other changes look okay.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62944/new/

https://reviews.llvm.org/D62944



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to