rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2370
+ if (CGM.getCodeGenOpts().CXAAtExit || D.getTLSKind())
return emitGlobalDtorWithCXAAtExit(CGF, dtor, addr, D.getTLSKind());
----------------
It's fine to match the GCC behavior, and it's even somewhat explicable. Could
you update the comment to explain, first of all, that this path handles both
`__cxa_atexit` and `__cxa_thread_atexit`, and secondly that the option is only
meant to control the former?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63283/new/
https://reviews.llvm.org/D63283
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
