nridge marked an inline comment as done. nridge added a comment. The fix actually broke another lit test, because in that test the client was not sending the diagnostic's code back in the `codeAction` request, resulting in a mismatch with the new comparison function.
I think a real client could potentially could this too (not send the code back), so I revised the fix to address this case, by only using the code in the comparison if it's present in both objects. Also added the requested new lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63316/new/ https://reviews.llvm.org/D63316 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
