Szelethus added inline comments.
================
Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:51
+ CFGDominatorTreeImpl(CFG *cfg) {
+ buildDominatorTree(cfg);
+ }
----------------
kuhar wrote:
> DomTree has a constructor that runs the builder -- why not use it directly?
That is correct, but `DomTreeBase` does not. :/
================
Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:160
/// changes.
void changeImmediateDominator(CFGBlock *N, CFGBlock *NewIDom) {
DT.changeImmediateDominator(N, NewIDom);
----------------
kuhar wrote:
> Do you need it at all? I understand it's a wrapper around dominators, but
> this API is virtually impossible to use safely.
I agree 100%, I'll get rid of this in another patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62619/new/
https://reviews.llvm.org/D62619
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
