Charusso accepted this revision.
Charusso marked an inline comment as done.
Charusso added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:222
+ Indent(Out, Space, IsDot) << "{ " << CI.getKey() << ", \"value\": ";
+ CI.getData().printJson(Out, true);
+ Out << " }";
----------------
Could you inject `/*AddQuotes=*/`?
================
Comment at: clang/test/Analysis/exploded-graph-rewriter/escapes.c:3
+// RUN: %clang_cc1 -analyze -analyzer-checker=core \
+// RUN: -analyzer-dump-egraph=%t.dot %s
+// RUN: %exploded_graph_rewriter %t.dot | FileCheck %s
----------------
I like that styling.
================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287
.replace('\\}', '}') \
+ .replace('\\\\', '\\') \
.replace('\\<', '\\\\<') \
----------------
I think this is the correct approach.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63519/new/
https://reviews.llvm.org/D63519
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
