aaron.ballman added a comment. In D63423#1547244 <https://reviews.llvm.org/D63423#1547244>, @regehr wrote:
> In D63423#1547216 <https://reviews.llvm.org/D63423#1547216>, @xbolva00 wrote: > > > The only remaining question is, as your said, whether or not to diagnose > > xors in macros. @regerh @jfb ? > > > IMO it's better to not warn about xors in macros-- I like the current > tradeoffs. Do you mind explaining why? I would have expected to diagnose an xor within a macro because the code is just as wrong there, but maybe I'm missing something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
