xazax.hun added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228 -ExprEngine::~ExprEngine() { - BR.FlushReports(); ---------------- NoQ wrote: > xazax.hun wrote: > > Hmm. Maybe add an assert that all the bug reports are flushed at this > > point? Just to make sure we never need this :) I am not insisting on this > > change just wondering. > Actually we already have the same code in `~BugReporter` itself, so this > assertion would be kinda trivial. Like, it wouldn't necessarily hold, as the > destructor for the field hasn't been executed at this point, but it's still > useless, because the destructor will be executed very soon. Makes sense, thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63227/new/ https://reviews.llvm.org/D63227 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits