rjmccall accepted this revision.
rjmccall added inline comments.
================
Comment at: include/clang/Basic/Attr.td:326
+ // const llvm::Triple &T = Target.getTriple();
+ code CustomCode = [{}];
}
----------------
Thanks!
================
Comment at: lib/CodeGen/CGExprAgg.cpp:1850
+AggValueSlot::Overlap_t
+CodeGenFunction::overlapForFieldInit(const FieldDecl *FD) {
+ if (!FD->hasAttr<NoUniqueAddressAttr>() || !FD->getType()->isRecordType())
----------------
rsmith wrote:
> rsmith wrote:
> > rjmccall wrote:
> > > `getOverlapForFieldInit`? `overlap` is a verb.
> > Good idea. (Both this and `overlapForBaseInit` are pre-existing; I'll
> > rename both.)
> I'm going to do this in a separate change since there are quite a few uses of
> these and it'll add noise to the patch.
SGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63451/new/
https://reviews.llvm.org/D63451
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
