jkorous added a comment. I don't have the insight to LGTM the whole change - just a nit about implementation detail.
================ Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); ---------------- You might consider using just a lambda with `llvm::make_scope_exit`. https://llvm.org/doxygen/namespacellvm.html#a4896534f3c6278be56967444daf38e3f For example: ``` To->startDefinition(); auto DefinitionCompleter = llvm::make_scope_exit( [To](){To->completeDefinition();} ); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
