xazax.hun added a comment. In D62883#1552870 <https://reviews.llvm.org/D62883#1552870>, @Szelethus wrote:
> - Now using `CFGBlock::getTerminatorConditionExpr()` > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair > instead of on `Expr` I would be surprised to see the same ExploderNode multiple time a lot. Also, ExploderNode will have a program point, so having both an ExploderNode and an Expr feels redundant to me. > - Add a `TODO:` about caching > - Add plenty of new test cases for good measure (examples from my latest mail > http://lists.llvm.org/pipermail/cfe-dev/2019-June/062613.html) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
