DiegoAstiazaran marked 12 inline comments as done.
DiegoAstiazaran added a comment.
A couple of comments that were related to the function writeDescription() were
marked as done since most of that function was deleted. Rendering of the other
kinds of CommentInfos will be handled later.
================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:25
+
+std::string genTag(const Twine &Text, const Twine &Tag) {
+ return "<" + Tag.str() + ">" + Text.str() + "</" + Tag.str() + ">";
----------------
jakehehrlich wrote:
> This can also be a Twine
I tried to change it to Twine but the output of OS << genTag() is empty.
================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:33-35
+void writeLine(const Twine &Text, raw_ostream &OS) {
+ OS << genTag(Text, "p") << "\n";
+}
----------------
jakehehrlich wrote:
> I'm not familiar with HTML. What does this '<p>' do?
It's a basic paragraph tag used to display text.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63180/new/
https://reviews.llvm.org/D63180
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
