DmitryPolukhin added a comment. Hi Stefan,
What are your plans about this patch? The patch has number of comments about Sema part from Aaron and me but in general there are no major issues with Sema for the attribute. As for mangling part I think recursive approach looks reasonable because alternative implementation will require re-implementation significant part of name mangling just to calculate abi_tags for types. So your approach minimizes code duplication. I made following changes in your patch F1448674: abi_tags.patch <http://reviews.llvm.org/F1448674>: - rebase on top-of-the-tree - fixed all failing tests (now check-clang has no unexpected fails) - fixed issue with mangling for variables in global namespace with abi_tags - partially fixed style/clang-format issues - added more tests on abi_tags (used the newest GCC mangling for templates with Jason's patches from Jan 31, 2016) If you are going to keep working on this patch, please integrate my patch in your patch. If you are not going to keep working on this patch, please let me know. Thanks, Dmitry Polukhin Software Engineer Intel Compiler Team Repository: rL LLVM http://reviews.llvm.org/D12834 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
