alexfh added inline comments.
================
Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:1
@@ -1,2 +1,2 @@
// RUN: %check_clang_tidy %s misc-virtual-near-miss %t
----------------
The check shouldn't make any changes to template classes based on any single
instantiation. An easy way to ensure this is to disallow matches in template
instantiations, e.g. using the `unless(isInTemplateInstantiation())` limiting
matcher.
================
Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:58
@@ +57,3 @@
+ MACRO1;
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: method 'Derived::funcM' has
{{.*}} 'Base::func'
+
----------------
Please move the #defines close to their usages and also verify they don't
change as a result of applying fixes.
http://reviews.llvm.org/D16922
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
