sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
LG from my side ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:28 Variable = 0, + MemberVariable, Function, ---------------- nit: clang calls these Field which is terser and pretty understandable, I think. (Formally, I think these are data members and "methods" are member functions, but I like the shorter names better) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64617/new/ https://reviews.llvm.org/D64617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
