Szelethus marked 2 inline comments as done. Szelethus added a comment. Would you say it's good to go? :)
================ Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1436-1437 - } - ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE->IgnoreParenCasts(), - BR, EnableNullFPSuppression); } ---------------- NoQ wrote: > You're removing this visitor, does it cause any removal of notes? Nope, `trackExpressionValue` will add it back, if appropriate. ================ Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1989-1991 + } + else if (const auto *AR = L->getRegionAs<AllocaRegion>()) + CanDereference = false; ---------------- NoQ wrote: > Fair enough. Did we already have a test case for this? I wonder if function > pointers might also cause problems here. > > Ugh, this code is so underdebugged. Yup, `test/Analysis/exercise-ps.c` flopped. And I agree, this looks kinda nasty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64287/new/ https://reviews.llvm.org/D64287 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
