sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:622
<< Pattern->getSourceRange();
+ CorrectDelayedTyposInExpr(Pattern);
return ExprError();
----------------
kadircet wrote:
> why not directly `return CorrectDelayedTyposInExpr(Pattern);` ?
Because the error isn't that `Pattern` is invalid per se (in a way that
CorrectDelayedTyposInExpr can see), but rather that there's no pack to expand.
So even if CorrectDelayedTyposInExpr returns something valid, we still want to
return ExprError(). We call it for its side-effects of flushing typos and
emitting diagnostics.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64677/new/
https://reviews.llvm.org/D64677
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
