Hi Bob, I've temporarily reverted this here:
echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 1dbd2f85903 Temporarily revert "add -fthinlto-index= option to clang-cl" Sending cfe/trunk/include/clang/Driver/Options.td Deleting cfe/trunk/test/Driver/cl-thinlto-backend.c Transmitting file data .done Committing transaction... Committed revision 366157. Committed 1dbd2f85903 to svn. as I was seeing testsuite failures on darwin release+asserts with the patch. Let's follow up offline if you can't duplicate. Thanks! -eric On Mon, Jul 15, 2019 at 3:49 PM Bob Haarman via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: inglorion > Date: Mon Jul 15 15:50:04 2019 > New Revision: 366146 > > URL: http://llvm.org/viewvc/llvm-project?rev=366146&view=rev > Log: > add -fthinlto-index= option to clang-cl > > Summary: > This adds a -fthinlto-index= option to clang-cl, which allows it to > be used to drive ThinLTO backend passes. This allows clang-cl to be > used for distributed ThinLTO. > > Reviewers: tejohnson, pcc, rnk > > Subscribers: mehdi_amini, steven_wu, dexonsmith, arphaman, cfe-commits > > Tags: #clang > > Differential Revision: https://reviews.llvm.org/D64458 > > Added: > cfe/trunk/test/Driver/cl-thinlto-backend.c > Modified: > cfe/trunk/include/clang/Driver/Options.td > > Modified: cfe/trunk/include/clang/Driver/Options.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=366146&r1=366145&r2=366146&view=diff > ============================================================================== > --- cfe/trunk/include/clang/Driver/Options.td (original) > +++ cfe/trunk/include/clang/Driver/Options.td Mon Jul 15 15:50:04 2019 > @@ -1270,7 +1270,7 @@ def flto_jobs_EQ : Joined<["-"], "flto-j > "of 0 means the number of threads will be derived from " > "the number of CPUs detected)">; > def fthinlto_index_EQ : Joined<["-"], "fthinlto-index=">, > - Flags<[CC1Option]>, Group<f_Group>, > + Flags<[CoreOption, CC1Option]>, Group<f_Group>, > HelpText<"Perform ThinLTO importing using provided function summary > index">; > def fmacro_backtrace_limit_EQ : Joined<["-"], "fmacro-backtrace-limit=">, > Group<f_Group>, Flags<[DriverOption, > CoreOption]>; > > Added: cfe/trunk/test/Driver/cl-thinlto-backend.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-thinlto-backend.c?rev=366146&view=auto > ============================================================================== > --- cfe/trunk/test/Driver/cl-thinlto-backend.c (added) > +++ cfe/trunk/test/Driver/cl-thinlto-backend.c Mon Jul 15 15:50:04 2019 > @@ -0,0 +1,9 @@ > +// RUN: %clang_cl -c -flto=thin -Fo%t.obj %s > +// RUN: llvm-lto2 run -thinlto-distributed-indexes -o %t.exe %t.obj > + > +// -fthinlto_index should be passed to cc1 > +// RUN: %clang_cl -### -c -fthinlto-index=%t.thinlto.bc -Fo%t1.obj \ > +// RUN: %t.obj 2>&1 | FileCheck %s > + > +// CHECK: -fthinlto-index= > +// CHECK: "-x" "ir" > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits