[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:1728
     }
+    assert(!FpKind.empty() && "unknown frame-pointer");
+    FuncAttrs.addAttribute("frame-pointer", FpKind);
----------------
The `assert` here is not very necessary.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3955
+  const char *FPKeepKindStr = nullptr;
+  switch(FPKeepKind) {
+  case CodeGenOptions::FramePointerKind::None:
----------------
Add a space after `switch`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56353/new/

https://reviews.llvm.org/D56353



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits