ldionne added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args, CmdArgs); + }); ---------------- So, before, we would populate `-stdlib=XXX` here unconditionally for `cc1`. After the patch, we do _not_ populate `-stdlib=XXX` and instead we pass `-internal-isystem` to `cc1` with the contents of `-stdlib++-isystem` whenever that option is provided, otherwise we fall back to the previous behaviour. Did I get that right? If so, could we investigate getting rid of `AddClangCXXStdlibIncludeArgs` altogether? I don't think it is needed anymore since my refactor of the driver for Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
