Sunil_Srivastava removed reviewers: wristow, rnk, rjmccall.
Sunil_Srivastava marked an inline comment as done.
Sunil_Srivastava added inline comments.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961
+def error_cconv_unsupported : Error<
+ "%0 calling convention not supported %select{"
+ // Use CallingConventionIgnoredReason Enum to specify these.
----------------
rnk wrote:
> This duplication merely to say "not supported" instead of "ignored" seems
> unfortunate. We could reasonable change "ignored" to "unsupported" and then
> you could use the warn_cconv_ignored.Text accessor to share the text.
Good point. I will make a pre-commit of just changing the wording (and
renaming) of warn_cconv_ignored. Then the warn_conv_unsupported.Text will be
used in the actual change.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64780/new/
https://reviews.llvm.org/D64780
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
